Skip to content

Update llvm-version.txt #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Update llvm-version.txt #204

merged 2 commits into from
Jul 31, 2024

Conversation

kurapov-peter
Copy link
Contributor

@kurapov-peter kurapov-peter commented Jul 31, 2024

Update to a version that has SPIRV backend working. Fixes a problem with #202 build.
The target is added to the compile script and the llvm build job for the github runner.

Update to a version that has SPIRV backend working
@kurapov-peter
Copy link
Contributor Author

FYI @leshikus, seems like there's a missing dependency between the llvm build and compiler build jobs.

Copy link
Contributor

@leshikus leshikus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leshikus leshikus merged commit 1b9d6ac into main Jul 31, 2024
5 checks passed
@kurapov-peter kurapov-peter deleted the kurapov-peter-patch-1 branch July 31, 2024 16:03
@dchigarev
Copy link
Contributor

dchigarev commented Aug 1, 2024

IMEX (our dev fork) can no longer be built with the new LLVM, should we pin older LLVM version for -DGC_USE_IMEX=ON builds or should we update our fork of IMEX to be compatible with the new LLVM ver? cc @kurapov-peter @Menooker

UPD:
aligning IMEX with the new llvm version appeared to be easier than I expected, so decided to go with this option (Menooker/mlir-extensions#2)

Menooker pushed a commit to Menooker/mlir-extensions that referenced this pull request Aug 2, 2024
This PR aligns IMEX with the new LLVM version in GC (introduced here: intel/graph-compiler#204)

The update has broken the following tests in IMEX (namely this assert statement now fails), I'm not sure what exactly caused this problem (my changes to IMEX or new LLVM versions). We don't use XeTile in our linalg->xegpu->gpu exe pipeline, so our flow is not affected by this problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants